[CHIA-3297] Port get_transaction(s) to @marshal
#19775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
the
Changed
Quexington
changed the title
get_transaction(s) to @marshalget_transaction(s) to @marshal
Quexington
force-pushed
the
quex.port_get_wallet_balance_s_to_marshal
branch
from
40940de to
954c9c7
Compare
github-actions
bot
added
the
merge_conflict
Quexington
force-pushed
the
quex.port_get_transaction_s_to_marshal
branch
from
11cb2f5 to
00f7040
Compare
github-actions
bot
added
merge_conflict
Base automatically changed from
quex.port_get_wallet_balance_s_to_marshal
to
main
August 5, 2025 20:11
Quexington
force-pushed
the
quex.port_get_transaction_s_to_marshal
branch
from
00f7040 to
34e0d25
Compare
github-actions
bot
removed
the
merge_conflict
Pull Request Test Coverage Report for Build 16820773625Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
altendky
suggested changes
Aug 7, 2025
Co-authored-by: Kyle Altendorf <[email protected]>
|
altendky
approved these changes
Aug 8, 2025
markelrod
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR following #18593
There's an unfortunate paradigm where we sometimes include metadata directly on the transaction record objects which makes schema-fication very annoying. I think this is the lightest touch we can have while maintaining backwards compatibility, but this should be on the top of the list of RPC patterns to deprecate.